This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Updating WPKit version #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Contributor
mindgraffiti
left a comment
mindgraffiti
left a comment
There was a problem hiding this comment.
Don't forget to bump the podspec for Authenticator to 1.13.0-beta.5 before you publish the release.
Contributor
Author
Well I surely did forget didn't I? @mindgraffiti thanks for that! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With wordpress-mobile/WordPressKit-iOS#241 the WPKit pod version was incremented. WPiOS failed to build because WPAuth depends on WPKit as well. So this simply updates WPKit pod version to make everyone happy!
Can be tested with WPiOS PR: wordpress-mobile/WordPress-iOS#13917
Note the
Validate Podspectest will continue to fail until there is an official WPKit release. I'll update that before merging. But you should be able to test locally successfully.